[Advanced Visibility with SQL] Adding PostgreSQL 12 schema and interface #3844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
force-pushed
the
advanced-visibility-postgresql-schema
branch
from
d4f7e50 to
b6f24ae
Compare
rodrigozhou
changed the title
rodrigozhou
force-pushed
the
advanced-visibility-postgresql-schema
branch
from
b6f24ae to
950fa2d
Compare
|
Could you paste a diff of the SQL files? That would make it easier to review |
|
@MichaelSnowden You can check the difference in the commits. The first commit is just a copy of the v96 schema plus formatting (no actual change). The second commit has the changes in the schema, and the third commit adds the interface and configs. |
rodrigozhou
force-pushed
the
advanced-visibility-postgresql-schema
branch
from
950fa2d to
c0b1743
Compare
rodrigozhou
force-pushed
the
advanced-visibility-postgresql-schema
branch
from
c0b1743 to
0cf053b
Compare
alexshtin
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added PostgreSQL 12 schemas:
Why?
Advanced visibility with SQL databases.
How did you test it?
Started temporal using PostgreSQL 12, and copied existing unit tests for PostgreSQL to use the new interface.
Potential risks
No.
Is hotfix candidate?
No.