Upgrade otel to 0.34 #3850
Upgrade otel to 0.34 #3850
Conversation
| counter := handler.WithTags(counterTags...).Counter(counterName) | ||
| counter.Record(1) | ||
| counter.Record(1) | ||
|
|
||
| s1 := handler.MustSnapshot() | ||
| require.Equal(t, float64(2), s1.MustCounter(counterName, counterTags...)) | ||
| require.Equal(t, float64(2), s1.MustCounter(counterName+"_total", expectedCounterTags...)) |
There was a problem hiding this comment.
Is this new _total suffix always added by otel, or is it configurable?
I wondering if this implies that enabling otel means that all counter based metrics, say in alerts or dashboard definitions, will break.
There was a problem hiding this comment.
There was a problem hiding this comment.
For users use otel, I think they will aware of this. For users switch from tally to otel, unfortunately, queries have to be updated.
There was a problem hiding this comment.
Wouldn't hurt to double check that our metrics are currently being exported that way via otel and we're not introducing a breaking change, just in case.
There was a problem hiding this comment.
This is a breaking change in otel.
There was a problem hiding this comment.
Does this change metric names for only the otel plugin, or all metrics plugins?
There was a problem hiding this comment.
Only otel.No breaking change in Tally.
There was a problem hiding this comment.
That's good, is there anything we need to do in this PR to note the breaking change so that users will be aware of it? It'll be a very important aspect of users upgrade path to ensure their dashboards and alerts continue working.
There was a problem hiding this comment.
I will update our 1.20 release note.
What changed?
Upgrade otel to 0.34
All counters have suffix _total
Why?
Upgrade otel to 0.34
How did you test it?
Update current unit tests
Potential risks
Is hotfix candidate?