Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle updating cluster metadata search attributes info when using SQL DB #3861

Merged

Conversation

rodrigozhou
Copy link
Contributor

What changed?
Register the pre-allocated custom search attributes when starting new instances of Temporal Server using SQL DB as visibility storage, or during the first start of the Server after upgrading to v1.20.

Why?
Support for advanced visibility using SQL DB: custom search attributes are pre-allocated and doing this automatically provides a more seamless experience to the user.

How did you test it?
Start new Server before changes, and then after. Logs show the search attributes being registered successfully:

{"level":"info","ts":"2023-01-27T17:16:01.894-0800","msg":"Successfully registered search attributes.","component":"metadata-initializer","cluster-name":"active","logging-call-at":"fx.go:733"}

Potential risks
No.

Is hotfix candidate?
No.

@rodrigozhou rodrigozhou requested a review from a team as a code owner January 28, 2023 01:18
@rodrigozhou rodrigozhou force-pushed the handle-cluster-metadata-upgrade branch from 72e3627 to c77a424 Compare January 31, 2023 19:58
@rodrigozhou rodrigozhou force-pushed the handle-cluster-metadata-upgrade branch from c77a424 to c513a33 Compare January 31, 2023 22:24
@rodrigozhou rodrigozhou merged commit 29afc2f into temporalio:master Jan 31, 2023
@rodrigozhou rodrigozhou deleted the handle-cluster-metadata-upgrade branch January 31, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants