Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix activity eager execution on workflow close #3868

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Fix activity eager execution on workflow close #3868

merged 1 commit into from
Jan 30, 2023

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Jan 30, 2023 •
edited
Loading

What changed?

  • Check for workflow completion when eagerly starting activity

Why?

  • Eager start activity is done after all commands have been processed, which means workflow may already be closed. Then AddActivityTaskStarted will fail on immutability check since no event can be added after workflow close.

How did you test it?

  • Added unit test.
  • Also reproed the issue locally and verified the fix resolves the issue.

Potential risks

Is hotfix candidate?

  • Can be

@yycptt yycptt requested a review from a team as a code owner January 30, 2023 18:48
@yycptt yycptt requested review from yiminc and yux0 January 30, 2023 18:48
@yycptt yycptt merged commit b40a4ac into temporalio:master Jan 30, 2023
@yycptt yycptt deleted the fix-activity-eager-execution branch January 30, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meiliang86 meiliang86 meiliang86 approved these changes

@yux0 yux0 yux0 approved these changes

@yiminc yiminc Awaiting requested review from yiminc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yycptt @meiliang86 @yux0