Add lower priority for replication tasks #3870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Jan 31, 2023
yux0
reviewed
Jan 31, 2023
Yeah, the plan is to use the new level/caller type for replication and all queues other than transfer/timer/visibility (@pdoerner Can you create a task for it). But that involves more changes: e.g right now task executable assumes all tasks are background, we need a ways to specify different caller type for different task categories. Same for the implementation on task loading. Given that the main motivation for this work is to resolve the issues we saw during namespace migration, I don't want to rush ^ changes for 1.20. |
yycptt
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a new rate limiter priority for preemptable tasks which is lower than other background tasks (currently the lowest priority)
Applied this new priority to replication tasks
Why?
Replication tasks should have lower priority than other tasks because it can hog resources and impact active namespaces in a cell. This will allow us to throttle replication tasks independently from other background tasks.
How did you test it?
Update unit test
Potential risks
No risks
Is hotfix candidate?
No