Advanced visibility for MySQL #3878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
force-pushed
the
adv-vis-mysql
branch
6 times, most recently
from
473734f to
1f6e518
Compare
alexshtin
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
We reviewed this PR together with @rodrigozhou, found some bugs, which are already addressed here. All the rest looks good as much as such big PR can be validated by human. Tests (unit and functional) are pending.
rodrigozhou
force-pushed
the
adv-vis-mysql
branch
from
1f6e518 to
7c6bf3b
Compare
rodrigozhou
force-pushed
the
adv-vis-mysql
branch
from
7c6bf3b to
7829aff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Implements the new advanced visibility store interface for SQL DB.
Implements new query converter.
Implements MySQL 8 query converter.
Why?
Advanced visibility for MySQL 8
How did you test it?
Ran local server, and run tests based on the custom search attributes sample code.
Potential risks
None.
Is hotfix candidate?
No.