Overwrite operation for admin and operator APIs #3890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
approved these changes
Feb 2, 2023
yux0
reviewed
Feb 2, 2023
|
LGTM. verified locally as well. |
meiliang86
approved these changes
Feb 2, 2023
alexshtin
approved these changes
Feb 2, 2023
yiminc
force-pushed
the
overwrite_operation
branch
from
d007604 to
88b06c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Prepend Admin/Operator to operation tag for operations from admin/operator handler.
Why?
Certain operation from admin/operator has same name as the ones from workflow service, for example DeleteWorkflowExecution. We used to prepend Admin/Operator to the operation tag, but it was missed in last metrics refactoring.
How did you test it?
New unit test
Potential risks
No.
Is hotfix candidate?
No