Update admin handler to handle search attributes operations with SQL DB #3894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Feb 2, 2023
rodrigozhou
force-pushed
the
update-admin-handler-sa
branch
from
74baccd to
99c8c7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update admin handler to handle search attributes operations when using SQL databases.
Similar changes to #3871.
Why?
Need to support both admin and operator handlers for now.
How did you test it?
Unit tests.
Started server locally using MySQL 8, and created/removed/listed search attributes using local tctl.
Potential risks
None.
Is hotfix candidate?
No.