Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced visibility for PostgreSQL #3896

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

rodrigozhou
Copy link
Contributor

What changed?
Implement PostgreSQL query converter for advanced visibility.
Implement PostgreSQL visibility_v12.go, the DB interface for advanced visibility.

Why?
Support advanced visibility for PostgreSQL 12+.

How did you test it?
Existing tests.
Started local server, and ran samples with custom search attributes.

Potential risks
None, it only affects new use cases using pluginName = postgres12.

Is hotfix candidate?
No.

@rodrigozhou rodrigozhou requested a review from alexshtin February 3, 2023 00:21
@rodrigozhou rodrigozhou requested a review from a team as a code owner February 3, 2023 00:21
Copy link
Member

@alexshtin alexshtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed together with @rodrigozhou. LGTM.

@rodrigozhou rodrigozhou merged commit 52d1ba0 into temporalio:master Feb 3, 2023
@rodrigozhou rodrigozhou deleted the adv-vis-pgsql branch February 3, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants