Fix namespace interceptor to allow search attributes operations #3899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
commented
Feb 3, 2023
Comment on lines
+212
to
+220
| string namespace = 3; | ||
| } | ||
|
|
||
| message RemoveSearchAttributesResponse { | ||
| } | ||
|
|
||
| message GetSearchAttributesRequest { | ||
| string index_name = 1; | ||
| string namespace = 4; | ||
| string namespace = 2; |
There was a problem hiding this comment.
This is just a fix in the arguments numbers. These are new arguments, and were not updated in tctl or cli yet. It should be safe.
Spikhalskiy
reviewed
Feb 3, 2023
| *operatorservice.ListSearchAttributesRequest: | ||
| // Namespace is optional for search attributes operations. | ||
| // It's required when using SQL DB for visibility, but not when using Elasticsearch. | ||
| if !namespaceName.IsEmpty() { |
Spikhalskiy
approved these changes
Feb 3, 2023
|
Should here be a unit test fixing the behavior? |
rodrigozhou
force-pushed
the
fix-ns-interceptor
branch
from
918645f to
222da72
Compare
|
@Spikhalskiy Added unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Let search attributes operations requests to pass without namespace set in the namespace interceptor.
Why?
Namespace interceptor validates the namespace argument of all requests if present.
However, this argument is optional for search attributes operations.
How did you test it?
Start server, and run tctl operations for search attributes no longer returns error "Namespace not set on request".
Potential risks
None.
Is hotfix candidate?
No.