Strict validation when using SQL DB for visibility #3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
commented
Feb 4, 2023
| // decodeValueTyped tries to decode to the given type. | ||
| // If the input is a list and allowList is false, then it will return only the first element. | ||
| // If the input is a list and allowList is true, then it will return the decoded list. | ||
| func decodeValueTyped[T any](value *commonpb.Payload, allowList bool) (any, error) { |
There was a problem hiding this comment.
I refactored and wrote a generic function to avoid code duplication.
alexshtin
approved these changes
Feb 6, 2023
rodrigozhou
force-pushed
the
strict-validation-sa
branch
from
49e9c39 to
3e2ecdd
Compare
rodrigozhou
force-pushed
the
strict-validation-sa
branch
from
3e2ecdd to
84ea8df
Compare
|
Thanks for addressing my concerns! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Implement strict mode to decode/validate search attributes. Strict mode don't allow list of values for the respective types. Only
KeywordListis allowed.It will be enabled by default when using SQL DB for visibility.
Why?
For now, we're still gonna let allow it for ES until the SDK start enforcing as well.
For SQL, it's not supported at all, so adding it to validation.
How did you test it?
Added unit tests.
Potential risks
It's no-op for existing usages.
Is hotfix candidate?
No.