Reduce unnecessary log noise #3918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
approved these changes
Feb 8, 2023
| // this should not happen, log warn and move on | ||
| i.logger.Warn(fmt.Sprintf("RedirectionInterceptor encountered unknown API: %v", methodName)) | ||
| // this should not happen for frontend APIs but ok for admin and other future handlers | ||
| // log warn and move on |
dnr
reviewed
Feb 8, 2023
| @@ -177,8 +177,9 @@ func (i *RedirectionInterceptor) Intercept( | |||
| return i.handleRedirectAPIInvocation(ctx, req, info, handler, methodName, respAllocFn, namespaceName) | |||
| } | |||
|
|
|||
| // this should not happen, log warn and move on | |||
| i.logger.Warn(fmt.Sprintf("RedirectionInterceptor encountered unknown API: %v", methodName)) | |||
| // this should not happen for frontend APIs but ok for admin and other future handlers | |||
There was a problem hiding this comment.
You can get the service name from info.FullMethod and log at Warn level for WorkflowService, and Debug level for AdminService or others. That might be more useful to catch bugs
There was a problem hiding this comment.
all workflow service APIs are validated
| i.logger.Warn(fmt.Sprintf("RedirectionInterceptor encountered unknown API: %v", methodName)) | ||
| // this should not happen for frontend APIs but ok for admin and other future handlers | ||
| // log warn and move on | ||
| i.logger.Debug(fmt.Sprintf("RedirectionInterceptor encountered unknown API: %v", methodName)) |
There was a problem hiding this comment.
Suggested change
| i.logger.Debug(fmt.Sprintf("RedirectionInterceptor encountered unknown API: %v", methodName)) | |
| i.logger.Debug("RedirectionInterceptor encountered unknown API", tag.Name(info.FullMethod)) |
I'd rather see the full name to know what service it's in
dnr
approved these changes
Feb 8, 2023
| // this should not happen, log warn and move on | ||
| i.logger.Warn(fmt.Sprintf("RedirectionInterceptor encountered unknown API: %v", methodName)) | ||
| // this should not happen for frontend APIs but ok for admin and other future handlers | ||
| i.logger.Debug(fmt.Sprintf("RedirectionInterceptor encountered unknown API: %v", info.FullMethod)) |
There was a problem hiding this comment.
I'd still rather use tags.. this is going to actually fmt.Sprintf on every non-workflowservice rpc, right?
There was a problem hiding this comment.
yes, and not only for admin but for operator also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
admin handler & other future handler does not need redirection, reduce unnecessary noise
How did you test it?
N/A
Potential risks
N/A
Is hotfix candidate?
N/A