Fix recreate custom search attribute after upgrade to advanced visibility with SQL #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Feb 13, 2023
rodrigozhou
force-pushed
the
fix-recreate-sa-sql
branch
from
bdd091c to
c8294ba
Compare
rodrigozhou
force-pushed
the
fix-recreate-sa-sql
branch
from
c8294ba to
300be8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
When adding custom search attributes, check cluster metadata only for ES.
With SQL, cluster metadata is never changed, so skip.
Why?
This allows user to re-create the custom search attributes after migrating to advanced visibility with SQL DB, and be able to transition smoothly.
How did you test it?
Started server with standard visibility, created a search attribute, restart server with advanced visibility, and tried to re-create the same search attribute.
Potential risks
No risks.
Is hotfix candidate?
No.