Fix Elasticsearch index creation in functional tests #3954
Conversation
alexshtin
force-pushed
the
fix/functional-tests-create-index
branch
from
f66832b to
fdd452e
Compare
alexshtin
force-pushed
the
fix/functional-tests-create-index
branch
3 times, most recently
from
15ab8b0 to
2c109de
Compare
alexshtin
force-pushed
the
fix/functional-tests-create-index
branch
from
2c109de to
e2031fe
Compare
| return err | ||
| } | ||
| if exists { | ||
| logger.Info("Index already exists.", tag.ESIndex(esConfig.GetVisibilityIndex())) |
There was a problem hiding this comment.
logger.Warn maybe? It seems that it should never happen.
However, I did see sometimes integration tests failing because index already existed.
There was a problem hiding this comment.
This is what I initially tried to address in this PR. It shouldn't happen in CI anymore. But locally, in debugging, if you stop debugger, for example, tests are not teared down properly.
| @@ -252,6 +258,70 @@ func NewCluster(options *TestClusterConfig, logger log.Logger) (*TestCluster, er | |||
| return &TestCluster{testBase: testBase, archiverBase: archiverBase, host: cluster}, nil | |||
| } | |||
|
|
|||
| func setupIndex(esConfig *esclient.Config, logger log.Logger) error { | |||
| esClient, err := esclient.NewIntegrationTestsClient(esConfig, logger) | |||
There was a problem hiding this comment.
What's the difference between NewIntegrationTestsClient and NewClient? L180 above uses the second one.
There was a problem hiding this comment.
NewIntegrationTestsClient is more like admin client which supports operation that are needed for tests only to do operations which are normally made outside of server (index template creation, index creation, etc). I have TODO there to properly separate them or, vice versa, merge in one.
What changed?
Fix Elasticsearch index creation in functional tests.
Why?
Recreation of index led to
flaky error.
How did you test it?
Run tests.
Potential risks
No risks.
Is hotfix candidate?
No.