Support CountWorkflowExecutions for SQL DB #3955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Feb 15, 2023
tests/advanced_visibility_test.go
Outdated
Comment on lines
1084
to
1087
| if !s.isElasticsearchEnabled() { | ||
| s.T().Skip("This test is only for Elasticsearch") | ||
| } | ||
|
|
| } | ||
|
|
||
| return fmt.Sprintf( | ||
| "SELECT COUNT(1) FROM executions_visibility WHERE %s", |
There was a problem hiding this comment.
Had to use ChatGPT to explain me what is COUNT(1) and why it is better than COUNT(*).
rodrigozhou
force-pushed
the
sql-count-workflows
branch
from
8d91f85 to
58868f4
Compare
yiminc
reviewed
Feb 15, 2023
| queryArgs = append(queryArgs, namespaceID.String()) | ||
|
|
||
| if len(queryString) > 0 { | ||
| whereClauses = append(whereClauses, fmt.Sprintf("(%s)", queryString)) |
There was a problem hiding this comment.
Do we have sql injection risk here?
There was a problem hiding this comment.
It shouldn't. The query converter escape the user's input.
| return fmt.Sprintf( | ||
| `SELECT COUNT(1) | ||
| FROM executions_visibility ev | ||
| LEFT JOIN custom_search_attributes |
There was a problem hiding this comment.
Is join here must have? PostgreSQL and SQLite were able to get away without join.
There was a problem hiding this comment.
Yes, in MySQL, we have two tables (executions + custom search attributes), so we need the join. I'm assuming the input can be on any search attribute. If it's only on system search attribute, we can remove the join.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Implement support for
CountWorkflowExecutionsfor advanced visibility with SQL DB.Why?
Advanced visibility with SQL DB.
How did you test it?
Enabled
TestCountWorkflowfunctional test.Potential risks
No risks.
Is hotfix candidate?
No.