DeleteExecutions workflow: pass nextPageToken with ContinueAsNewError #3966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hehaifengcn
reviewed
Feb 16, 2023
| @@ -186,6 +187,7 @@ func DeleteExecutionsWorkflow(ctx workflow.Context, params DeleteExecutionsParam | |||
| params.PreviousSuccessCount = result.SuccessCount | |||
| params.PreviousErrorCount = result.ErrorCount | |||
| params.ContinueAsNewCount++ | |||
| params.NextPageToken = nextPageToken | |||
|
|
|||
| logger.Info("There are more workflows to delete. Continuing workflow as new.", tag.WorkflowType(WorkflowName), tag.WorkflowNamespace(params.Namespace.String()), tag.DeletedExecutionsCount(result.SuccessCount), tag.DeletedExecutionsErrorCount(result.ErrorCount), tag.Counter(params.ContinueAsNewCount)) | |||
There was a problem hiding this comment.
nit: I think workflow execution history is good enough so this logging is not really needed.
hehaifengcn
approved these changes
Feb 16, 2023
yiminc
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
DeleteExecutions workflow: pass
nextPageTokenwithContinueAsNewError.Why?
To prevent DeleteExecutions workflow to start from the begining with every "continue as new" iteration.
How did you test it?
Modified existing test.
Potential risks
No risks.
Is hotfix candidate?
No.