Suport dual visibility in visibility persistence checks #3968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
approved these changes
Feb 16, 2023
| @@ -1038,7 +1038,7 @@ func (adh *AdminHandler) DescribeCluster( | |||
| ClusterName: metadata.ClusterName, | |||
| HistoryShardCount: metadata.HistoryShardCount, | |||
| PersistenceStore: adh.persistenceExecutionManager.GetName(), | |||
| VisibilityStore: adh.visibilityMgr.GetName(), | |||
| VisibilityStore: strings.Join(adh.visibilityMgr.GetStoreNames(), ","), | |||
There was a problem hiding this comment.
I see this is used in a couple of places. Should we have a function to retrieve the store names as string? Worried about fragmentation, and eventually someone calling Join with another separator by accident.
alexshtin
force-pushed
the
fix/split-get-name
branch
from
5bd3b16 to
29d9471
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Suport dual visibility in visibility persistence checks.
Why?
If dual visibility is enables, store name is not just a string but concatenated string. This PR changes it to the slice of stores and does a proper check.
How did you test it?
Existing tests.
Potential risks
No risks.
Is hotfix candidate?
No.