Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Chart.Version as container tag, remove /app from url #95

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Use Chart.Version as container tag, remove /app from url #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/upload_release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,5 +77,5 @@ jobs:

- name: 'Build Image'
run: |
docker buildx build --output type=docker --tag ghcr.io/${{ env.REPO_LC }}/app:${{ github.event.release.tag_name }} --tag ghcr.io/${{ env.REPO_LC }}/app:latest .
docker push ghcr.io/${{ env.REPO_LC }}/app --all-tags
docker buildx build --output type=docker --tag ghcr.io/${{ env.REPO_LC }}:${{ github.event.release.tag_name }} --tag ghcr.io/${{ env.REPO_LC }}:latest .
docker push ghcr.io/${{ env.REPO_LC }} --all-tags
2 changes: 1 addition & 1 deletion k8s_01/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
name: host-var-lib-docker-containers
containers:
- name: kubelogreader
image: "{{.Values.image.repository}}/{{.Values.image.path}}:{{.Values.image.tag}}"
image: "{{.Values.image.repository}}/{{.Values.image.path}}:{{.Chart.Version}}"
imagePullPolicy: {{.Values.image.pullPolicy}}
securityContext:
privileged: true
Expand Down
5 changes: 2 additions & 3 deletions k8s_01/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
image:
# Image will be downloaded from {repository}/{path}:{tag}
# Image will be downloaded from {repository}/{path}:{Tag from Chart.Version}
repository: ghcr.io
path: teragrep/k8s_01/app
tag: latest
path: teragrep/k8s_01
pullPolicy: IfNotPresent

config:
Expand Down