Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#277: where command does not work as expected with boolean expressions #365

Merged
merged 3 commits into from
Oct 21, 2024
Merged

#277: where command does not work as expected with boolean expressions #365

merged 3 commits into from
Oct 21, 2024

Conversation

Abigael-JT
Copy link
Contributor

@Abigael-JT Abigael-JT commented Oct 4, 2024 •
edited by eemhu
Loading

Changes made:

  • Removed unused "visitEvalStatement" from EvalStatement.java
  • Replace getChild with evalStatement in WhereTransformation
  • Enabled disabled where tests
  • Fixed logic in eval logic statement

Related ticket

@Abigael-JT Abigael-JT mentioned this pull request Oct 7, 2024
Closed
@Abigael-JT Abigael-JT marked this pull request as ready for review October 8, 2024 06:46
@Abigael-JT Abigael-JT marked this pull request as draft October 8, 2024 10:30
@Abigael-JT
Copy link
Contributor Author

Rebase done

@Abigael-JT
Enabled where disabled tests, removed unused visitEvalStatement and r…
81bb2a4 
…eplaced getChild(1) with EvalStatement() in WhereTransformation
@eemhu eemhu changed the title ISSUE-277 #277: where command does not work as expected with boolean expressions Oct 14, 2024
@eemhu eemhu marked this pull request as ready for review October 14, 2024 09:52
@eemhu eemhu requested a review from elliVM October 14, 2024 09:53
@Abigael-JT Abigael-JT requested a review from kortemik October 16, 2024 07:20
@eemhu eemhu requested a review from kortemik October 21, 2024 08:39
@kortemik kortemik merged commit 4a46374 into teragrep:main Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemhu eemhu eemhu left review comments

@kortemik kortemik kortemik approved these changes

@elliVM elliVM elliVM approved these changes

Assignees

@eemhu eemhu

@Abigael-JT Abigael-JT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Abigael-JT @kortemik @eemhu @elliVM