Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BloomFilter equals tests and refactoring #448

Merged
merged 3 commits into from
Dec 9, 2024
Merged

BloomFilter equals tests and refactoring #448

merged 3 commits into from
Dec 9, 2024

Conversation

51-code
Copy link
Contributor

@51-code 51-code commented Dec 5, 2024

Fixes #440 .

  • Adds equalsVerifier tests. TeragrepBloomStep didn't get one, see issue Improve translation tests #446 . Also objects that take a Context object as a parameter (from ANTLR) didn't work with equalsVerifier.
  • Renamed ModeFromBloomContext to ContextBloomMode.
  • Refactored ToBloomFilter. In fix issues pointed in pr #414 #440, it was asked to fix hashCode and equals functions. The cache was mutable however, so equals tests didn't work. Refactored it so that it no longer extends BloomFilter, just offers the function to create a BloomFilter from bytes (originally that function was called first, creating a BloomFilter and then delegating function calls to the BloomFilter). I think this made the object simpler.

@51-code 51-code added the feature Existing feature label Dec 5, 2024
@51-code 51-code requested a review from eemhu December 5, 2024 10:11
@51-code 51-code self-assigned this Dec 5, 2024
@51-code 51-code requested a review from eemhu December 9, 2024 07:08
@51-code 51-code requested a review from elliVM December 9, 2024 07:28
elliVM
elliVM approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@elliVM elliVM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@51-code 51-code requested a review from kortemik December 9, 2024 08:48
@51-code 51-code requested a review from kortemik December 9, 2024 10:22
@kortemik kortemik merged commit 08872b8 into teragrep:main Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kortemik kortemik kortemik approved these changes

@eemhu eemhu eemhu approved these changes

@elliVM elliVM elliVM approved these changes

Assignees

@51-code 51-code

Labels
feature Existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix issues pointed in pr #414
4 participants
@51-code @kortemik @eemhu @elliVM