Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config.TryLoadRootConfig config detection #235

Merged
merged 8 commits into from
Feb 25, 2022

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Feb 24, 2022

No description provided.

@i4ki i4ki changed the base branch from main to i4k/fix-git-config-cli February 24, 2022 20:02
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #235 (973c7a3) into main (409f724) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head 973c7a3 differs from pull request most recent head 24f3cc0. Consider uploading reports for the commit 24f3cc0 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
- Coverage   64.95%   64.89%   -0.07%     
==========================================
  Files          30       30              
  Lines        5613     5603      -10     
==========================================
- Hits         3646     3636      -10     
  Misses       1782     1782              
  Partials      185      185              
Flag Coverage Δ
tests 64.89% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/terramate/cli/cli.go 0.00% <0.00%> (ø)
config/config.go 100.00% <ø> (+3.84%) ⬆️
git/git.go 74.40% <0.00%> (-0.34%) ⬇️
manager.go 60.79% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 409f724...24f3cc0. Read the comment docs.

@i4ki i4ki requested a review from katcipis February 24, 2022 23:05
@katcipis katcipis changed the title fix: root config loading fix: config.TryLoadRootConfig config detection Feb 25, 2022
Base automatically changed from i4k/fix-git-config-cli to main February 25, 2022 12:32
@i4ki i4ki merged commit c602e01 into main Feb 25, 2022
@i4ki i4ki deleted the i4k/fix-root-config-loading branch February 25, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants