fix: ignore deleted directories not part of a stack in change detection #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i4ki
force-pushed
the
i4k-fix-change-detection-deleted-file
branch
from
b9ac89e to
1036aa7
Compare
i4ki
changed the title
Codecov Report
@@ Coverage Diff @@
## main #287 +/- ##
==========================================
+ Coverage 63.97% 64.05% +0.08%
==========================================
Files 31 31
Lines 5984 5984
==========================================
+ Hits 3828 3833 +5
+ Misses 1944 1939 -5
Partials 212 212
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
katcipis
previously approved these changes
Mar 31, 2022
cmd/terramate/e2etests/list_test.go
Outdated
| assertRun(t, cli.listChangedStacks()) | ||
| } | ||
|
|
||
| func TestListChangedDontIgnoreStackDeletedFilesInGitDiff(t *testing.T) { |
There was a problem hiding this comment.
Suggested change
| func TestListChangedDontIgnoreStackDeletedFilesInGitDiff(t *testing.T) { | |
| func TestListChangedDetectsDeletedStackSubdirFiles(t *testing.T) { |
cmd/terramate/e2etests/list_test.go
Outdated
Comment on lines
227
to
228
| git.Add(".") | ||
| git.Commit("all") |
There was a problem hiding this comment.
Suggested change
| git.Add(".") | |
| git.Commit("all") | |
| git.CommitAll("all") |
cmd/terramate/e2etests/list_test.go
Outdated
| }) | ||
| } | ||
|
|
||
| func TestListChangedDontIgnoreStackDeletedDirectoriesInGitDiff(t *testing.T) { |
There was a problem hiding this comment.
Suggested change
| func TestListChangedDontIgnoreStackDeletedDirectoriesInGitDiff(t *testing.T) { | |
| func TestListChangedDetectsDeletedStackSubdir(t *testing.T) { |
cmd/terramate/e2etests/list_test.go
Outdated
Comment on lines
252
to
253
| git.Add(".") | ||
| git.Commit("all") |
There was a problem hiding this comment.
Suggested change
| git.Add(".") | |
| git.Commit("all") | |
| git.CommitAll("all") |
cmd/terramate/e2etests/list_test.go
Outdated
Comment on lines
259
to
260
| git.Add(".") | ||
| git.Commit("removed directory") |
There was a problem hiding this comment.
Suggested change
| git.Add(".") | |
| git.Commit("removed directory") | |
| git.CommitAll("removed directory") |
cmd/terramate/e2etests/list_test.go
Outdated
Comment on lines
234
to
235
| git.Add(".") | ||
| git.Commit("removed file") |
There was a problem hiding this comment.
Suggested change
| git.Add(".") | |
| git.Commit("removed file") | |
| git.CommitAll("removed file") |
cmd/terramate/e2etests/list_test.go
Outdated
Comment on lines
212
to
213
| git.Add(".") | ||
| git.Commit("removed stack") |
There was a problem hiding this comment.
Suggested change
| git.Add(".") | |
| git.Commit("removed stack") | |
| git.CommitAll("removed stack") |
cmd/terramate/e2etests/list_test.go
Outdated
Comment on lines
205
to
206
| git.Add(".") | ||
| git.Commit("all") |
There was a problem hiding this comment.
Suggested change
| git.Add(".") | |
| git.Commit("all") | |
| git.CommitAll("all") |
katcipis
previously approved these changes
Mar 31, 2022
cmd/terramate/e2etests/list_test.go
Outdated
| git := s.Git() | ||
| git.CommitAll("all") | ||
| git.Push("main") | ||
| git.CheckoutNew("deleted-file") |
There was a problem hiding this comment.
Suggested change
| git.CheckoutNew("deleted-file") | |
| git.CheckoutNew("deleted-dir") |
katcipis
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.