WPS plugins #230
Merged
WPS plugins #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking into this now. |
marcjansen
approved these changes
Feb 21, 2017
| .appendSuper(super.hashCode()) | ||
| .append(getName()) | ||
| .append(getClassName()) | ||
| .append(getXtype()) |
There was a problem hiding this comment.
Did you leave out sourceCode and styleSheet on purpose? What about fileUploads?
There was a problem hiding this comment.
Nice catch (regarding sourceCode and styleSheet). I'll add them now, but leave out fileUploads to avoid lazy loading of related entities...
| .append(getName(), other.getName()) | ||
| .append(getClassName(), other.getClassName()) | ||
| .append(getXtype(), other.getXtype()) | ||
| .isEquals(); |
| .append("name", name) | ||
| .append("className", className) | ||
| .append("xtype", xtype) | ||
| .toString(); |
| .appendSuper(super.hashCode()) | ||
| .append(getUrl()) | ||
| .append(getMimeType()) | ||
| .append(getMethod()) |
There was a problem hiding this comment.
I think the information used here (url, mimeType, method and the properties from the parent class) should be enough to make this unique. Leaving the body out could increase performance as lazy loading is avoided...
| .appendSuper(super.equals(other)) | ||
| .append(getUrl(), other.getUrl()) | ||
| .append(getMimeType(), other.getMimeType()) | ||
| .append(getMethod(), other.getMethod()) |
| .appendSuper(super.toString()) | ||
| .append("url", url) | ||
| .append("mimeType", mimeType) | ||
| .append("method", method) |
|
👍 all good now |
marcjansen
approved these changes
Feb 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(There has just been a new release of shogun2: https://github.com/terrestris/shogun2/releases/tag/v0.1.2)
This PR will merge the current state of the
wps-pluginsbranch (https://github.com/terrestris/shogun2/tree/wps-plugins) to master.Essentially, the following new models will be introduced:
Pluginas base class ofWpsPluginWpsParameteras (abstract) base class ofWpsPrimitiveandWpsReference, which again is the parent class ofWpsProcessExecute(On top of the models, this PR also contains the corresponding
DAOs,Services andRest-/Controllers.)An
Applicationnow has a list ofPlugins, where aPluginmainly is a piece of (JS/Ext-JS)sourceCodethat could follow some kind of policy/guideline that is expected by a client (e.g. it could implement aloadorinitfunction, which is then interpreted by a client) and may (for example) be used to provide a basic input-GUI for aWpsPrimitive.