Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace aware handling in default WMS request/response interceptor (1.0.x-master) #352

Merged

Conversation

dnlkoch
Copy link
Member

@dnlkoch dnlkoch commented May 3, 2019

This fixes the interception of WMS requests and responses in context of the CUSTOM_ENDPOINT handling to become more namespace aware:

  • Append xlink namespace to element attribute (otherwise clients like QGIS couldn't parse the GetCapabilities response).
  • Append the layer's namespace to layername if needed (otherwise we couldn't detect the corresponding GeoServer base URL in subsequent WMS requests as clients like QGIS will make use of the name to generate these requests).
  • Add @Transactional annotation to enforce a new JTA transaction if called outside of a transaction context.

Please review @terrestris/devs.

@dnlkoch dnlkoch changed the title Namespace aware handling in default WMS request/response interceptor Namespace aware handling in default WMS request/response interceptor (1.0.x-master) May 3, 2019
@hwbllmnn
Copy link
Member

hwbllmnn commented May 3, 2019

LGTM, please merge

@dnlkoch dnlkoch merged commit b9f0c46 into terrestris:1.0.x-master May 7, 2019
@dnlkoch dnlkoch deleted the fix-published-service-via-interceptor branch May 7, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants