Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Do not pre-pull cached images #1032

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

HofmeisterAn
Copy link
Collaborator

@HofmeisterAn HofmeisterAn commented Oct 19, 2023

What does this PR do?

The pull request prevents Testcontainers from pre-pulling (existing) images during the image build process.

Why is it important?

In recent versions, Testcontainers has begun pre-pulling images during the image build process to ensure that the required images are present on the Docker host that runs the image build process. Having the necessary base images (stages) on the Docker host is necessary for a successful image build.

Related issues

-

@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Oct 19, 2023
@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit bc9dc7e
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/653428f3cdbab40007e92ede
😎 Deploy Preview https://deploy-preview-1032--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn merged commit 082eea4 into develop Oct 21, 2023
@HofmeisterAn HofmeisterAn deleted the feature/do-not-prepull-existing-images branch October 21, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant