Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Bigtable module #1046

Merged
merged 9 commits into from
Nov 24, 2023

Conversation

peroyhav
Copy link
Contributor

@peroyhav peroyhav commented Nov 9, 2023

Add Bigtable emulator container

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 5396fd6
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/65610e9b48e2830008d0b562
😎 Deploy Preview https://deploy-preview-1046--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@peroyhav peroyhav force-pushed the add-bigtable-emulator branch from 34070a8 to 7d9252c Compare November 9, 2023 11:34
@peroyhav peroyhav changed the title Add Bigtable emulator and tests. Add Bigtable module Nov 9, 2023
@peroyhav peroyhav force-pushed the add-bigtable-emulator branch from f034887 to 97b0b16 Compare November 9, 2023 15:47
@peroyhav
Copy link
Contributor Author

peroyhav commented Nov 9, 2023

Trying to force update to check if tests failed due to error on my part, or some issue elsewhere. No report of failure found.

@peroyhav
Copy link
Contributor Author

peroyhav commented Nov 9, 2023

@HofmeisterAn I believe this is ready for review.
Using the BigtableTableAdminClient to test that it works as expected by creating and retrieving a table.

@HofmeisterAn
Copy link
Collaborator

@HofmeisterAn I believe this is ready for review. Using the BigtableTableAdminClient to test that it works as expected by creating and retrieving a table.

Thank you for the PR. I'll review it within the next few days as soon as I have some free time 🕐. I've already taken a brief look, and it seems good so far.

@HofmeisterAn HofmeisterAn changed the title Add Bigtable module feat: Add Bigtable module Nov 24, 2023
@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Nov 24, 2023
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, pull request and for addressing the change requests. PR looks good 🙏.

@HofmeisterAn HofmeisterAn merged commit e9b48db into testcontainers:develop Nov 24, 2023
@peroyhav
Copy link
Contributor Author

Thank you for the contribution, pull request and for addressing the change requests. PR looks good 🙏.

Thanks, will the Bigtable module be available upon next release, and when approximately can I expect it to be available?

@HofmeisterAn
Copy link
Collaborator

Yes, it will be included in the next release. There is no ETA yet (I do not think it is urgent, you can always fall back on the generic builder). I would like to include a couple more features; having a preview of the reusable API would be awesome.

@peroyhav
Copy link
Contributor Author

No problem, I've used copyed the implementation into the project where I needed it anyway, just want to throw the code out to reduce code lines required to maintain within the projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants