-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Bigtable module #1046
feat: Add Bigtable module #1046
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
34070a8
to
7d9252c
Compare
f034887
to
97b0b16
Compare
Trying to force update to check if tests failed due to error on my part, or some issue elsewhere. No report of failure found. |
@HofmeisterAn I believe this is ready for review. |
Thank you for the PR. I'll review it within the next few days as soon as I have some free time 🕐. I've already taken a brief look, and it seems good so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, pull request and for addressing the change requests. PR looks good 🙏.
Thanks, will the Bigtable module be available upon next release, and when approximately can I expect it to be available? |
Yes, it will be included in the next release. There is no ETA yet (I do not think it is urgent, you can always fall back on the generic builder). I would like to include a couple more features; having a preview of the reusable API would be awesome. |
No problem, I've used copyed the implementation into the project where I needed it anyway, just want to throw the code out to reduce code lines required to maintain within the projects. |
Add Bigtable emulator container