chore: Use relative ProjectReference paths instead of $(SolutionDir) #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
0xced
force-pushed
the
RelativeProjectReferences
branch
from
c29aad8 to
ca6f7a6
Compare
HofmeisterAn
added
the
chore
HofmeisterAn
changed the title
HofmeisterAn
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request replaces all usage of
$(SolutionDir)with relative paths instead.Why is it important?
When using Testcontainers project directly from source, using
$(SolutionDir)interferes since the$(SolutionDir)will be defined for the currently opened solution instead ofTestcontainers.sln. Using relative paths work both forTestcontainers.slnandMyApp.sln. Using Testcontainers direclty from source is required to test bleeding edge feature such asWithReuse(true)which was introduced a few days ago.Note
directly from source means using
instead of
Related issues
None