fix: Consider the timestamp in the log message wait strategy (read the correct log message chunk) #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…while starting an existing container
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…d-started-stopped-container-timestamp-pass-wait-strategy
HofmeisterAn
deleted the
feature/set-created-started-stopped-container-timestamp-pass-wait-strategy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR adds three new properties,
CreatedTime,StartedTime, andStoppedTime, to theIContainerinterface. The timestamp is assigned to the properties according to the state of the container.Why is it important?
The log message wait strategy, until now, did not consider the timestamp from when it should read the container logs. Starting an already existing container (
StopAsync(),StartAsync()) indicated the readiness of the container too early because the log messages were already present from the previous start. With the introduced changes, the log messages wait strategy will only include container log messages after the stopped timeout. This ensures that the wait strategy does not test against log messages generated from previous runs.Starting an existing container may still run into issues if the log message wait strategy is not compatible with the different behaviors or outputs of the container. In some cases, the wait strategies need to be adjusted. We have noticed cases where container logs differ on the first attempt.
Related issues