Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add getter for Azurite blob, queue and table endpoint #1278

Merged
merged 1 commit into from
Oct 14, 2024
Merged

feat: Add getter for Azurite blob, queue and table endpoint #1278

merged 1 commit into from
Oct 14, 2024

Conversation

pregress
Copy link
Contributor

What does this PR do?

Exposes extra methods on azurite to get the individual endpoints for blob, queue & table.
This is useful if managed identity is used in the actual implementation.

Why is it important?

The storage connection string parser is internal in the azure sdk.

Related issues

n/a

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit ca73e85
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/670cea4fa66352000865e01a
😎 Deploy Preview https://deploy-preview-1278--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Oct 14, 2024
@HofmeisterAn HofmeisterAn changed the title Azurite get endpoints feat: Add getter for Azurite blob, queue and table endpoint Oct 14, 2024
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@HofmeisterAn HofmeisterAn merged commit a75cb73 into testcontainers:develop Oct 14, 2024
11 checks passed
@joelbourbon
Copy link

What does this PR do?

[...] This is useful if managed identity is used in the actual implementation.

@pregress Curious to know how this helps with Managed Identity specifically.

@pregress
Copy link
Contributor Author

What does this PR do?

[...] This is useful if managed identity is used in the actual implementation.

@pregress Curious to know how this helps with Managed Identity specifically.

If you use this ctor: https://learn.microsoft.com/en-us/dotnet/api/azure.data.tables.tableserviceclient.-ctor?view=azure-dotnet#azure-data-tables-tableserviceclient-ctor(system-uri-azure-core-tokencredential-azure-data-tables-tableclientoptions)

And your environment under test uses the URI in the environment variables. You need the URI and not the connection string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants