fix: Add HTTP wait strategy to prevent race-condition in WaitUntilHttpRequestIsSucceededTest #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pRequestIsSucceededTest
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HofmeisterAn
deleted the
bugfix/fix-race-condition-test-file-exists-in-container
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a race-condition in tests that depend on HTTP responses. Previously, we used
ncto listen for HTTP requests and send responses. However,nccannot handle multiple incoming connections, and there is a small window where no listener is available. This could end up in flaky behavior.The changes leverage
socatto send HTTP responses, which works reliably for multiple incoming requests.Why is it important?
-
Related issues