Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add test to ensure that all test projects are configured for CI #1305

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Nov 23, 2024

What does this PR do?

This pull request introduces a new test to ensure that all test projects are configured for Continuous Integration & Delivery.

Why is it important?

Because it's too easy to forget to add a line in the cicd.yml after creating a new module. This new test will catch this common error.

Related issues

This is a safety measure after the introduction of running each test project on a separate runner in #1295.

How to test this PR

Of course if the { name: "Testcontainers", runs-on: "ubuntu-22.04" } line is deleted from the cicd.yaml file then this new test won't run. 🙃

Because it's too easy to forget to add a line in the cicd.yml after creating a new module.

This is a safety measure after the introduction of running each test project on a separate runner in testcontainers#1295.
Copy link

netlify bot commented Nov 23, 2024

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit fe974c9
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/6741df2f36c3460009068352
😎 Deploy Preview https://deploy-preview-1305--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn added the chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups label Nov 24, 2024
@HofmeisterAn HofmeisterAn changed the title Add a new test that ensure that all test projects are configured for CI chore: Add test to ensure that all test projects are configured for CI Nov 24, 2024
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@HofmeisterAn HofmeisterAn merged commit 6051cdb into testcontainers:develop Nov 24, 2024
55 checks passed
@0xced 0xced deleted the ensure-all-test-projects-are-configured branch November 24, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants