Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lowkey Vault module #1344

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from

Conversation

Xor-el
Copy link

@Xor-el Xor-el commented Jan 19, 2025

What does this PR do?

Adds new module to support Lowkey Vault.

Why is it important?

This makes it possible for us to write Integration Tests for services that rely on Azure Key Vault.

Related issues

How to test this PR

Automated tests have been added to the project that verifies connectivity, test set/get secrets and create/download certificates.

Follow-ups

None at this time.

Copy link

netlify bot commented Jan 19, 2025

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit db8ffe2
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/67de9f7d0d87370008ac1f49
😎 Deploy Preview https://deploy-preview-1344--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Xor-el Xor-el force-pushed the feature/add-lowkey-vault-support branch from 7990cdc to d27c20f Compare February 1, 2025 18:53
@Xor-el
Copy link
Author

Xor-el commented Mar 21, 2025

Hi @HofmeisterAn sorry to bother you, but would you be able to review this when you get a chance? Appreciate it!

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're not bothering me at all. Thanks for the PR and your contribution! I was just busy with work related stuff over the past few days. I know I'm behind on reviewing PRs. I'm trying to keep up with the time I have while balancing work and family commitments.

I took a look at it, and I think we need to discuss or address a few things before we can merge the PR. Mainly, we need to review the APIs that the container builder offers. Are they truly necessary to run a Lowkey Vault instance?

@Xor-el Xor-el requested a review from HofmeisterAn March 22, 2025 11:34
@Xor-el
Copy link
Author

Xor-el commented Mar 26, 2025

Hi @HofmeisterAn just letting you know that the changes requested has been done in case you missed that and review re-requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add Lowkey Vault Test Container
2 participants