-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lowkey Vault module #1344
base: develop
Are you sure you want to change the base?
Add Lowkey Vault module #1344
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
7990cdc
to
d27c20f
Compare
…/Xor-el/testcontainers-dotnet into feature/add-lowkey-vault-support
Hi @HofmeisterAn sorry to bother you, but would you be able to review this when you get a chance? Appreciate it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're not bothering me at all. Thanks for the PR and your contribution! I was just busy with work related stuff over the past few days. I know I'm behind on reviewing PRs. I'm trying to keep up with the time I have while balancing work and family commitments.
I took a look at it, and I think we need to discuss or address a few things before we can merge the PR. Mainly, we need to review the APIs that the container builder offers. Are they truly necessary to run a Lowkey Vault instance?
Hi @HofmeisterAn just letting you know that the changes requested has been done in case you missed that and review re-requested. |
What does this PR do?
Adds new module to support Lowkey Vault.
Why is it important?
This makes it possible for us to write Integration Tests for services that rely on Azure Key Vault.
Related issues
How to test this PR
Automated tests have been added to the project that verifies connectivity, test set/get secrets and create/download certificates.
Follow-ups
None at this time.