Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SFTP module #1362

Merged
merged 8 commits into from
Feb 10, 2025
Merged

Conversation

wim07101993
Copy link
Contributor

What does this PR do?

Adds a test container for an SFTP server. I implemented the atmoz/sftp server.

Why is it important?

There is no container for SFTP yet.

Related issues

none

How to test this PR

Create a test container and write a file to it.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 439bff9
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/67aa2c245ea1780008548e6a
😎 Deploy Preview https://deploy-preview-1362--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I made some minor changes to align with the repository standards. I also noticed that uploading a file fails. I think we should address this issue before merging the PR.

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@HofmeisterAn HofmeisterAn added enhancement New feature or request module An official Testcontainers module labels Feb 10, 2025
@HofmeisterAn HofmeisterAn changed the title feat: implemented SFTP container atmoz/sftp feat: Add SFTP module Feb 10, 2025
@HofmeisterAn HofmeisterAn merged commit c56c495 into testcontainers:develop Feb 10, 2025
59 checks passed
@wim07101993 wim07101993 deleted the feat/sftp branch February 11, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module An official Testcontainers module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants