chore: Add WithAcceptLicenseAgreement(bool) to container builder #1370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a new container builder method
WithAcceptLicenseAgreement(bool)
, which provides a base implementation and makes it easier for developers to implement modules that require license agreements.Basically, modules need to override the following and call
ValidateLicenseAgreement()
in theirBuild()
method. I expect modules to overrideWithAcceptLicenseAgreement(bool)
and include proper documentation that references the relevant license information.Why is it important?
Recent module PRs include more and more modules that require license agreements. Previously, the code to check license acceptance was always copied manually. This PR simplifies the implementation of license acceptance, reduces code duplication, and ensures a consistent pattern across all modules.
Related issues
-