Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EventHubs, ServiceBus): Replace wait strategy with HTTP health check #1398

Merged

Conversation

scrocquesel-ml150
Copy link
Contributor

What does this PR do?

Reduce startup time of the service bus testcontainer by up to 10 seconds using the new available features.

Why is it important?

Reduce total test run time.

Related issues

Copy link

netlify bot commented Mar 12, 2025

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 3da6d63
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/67d1b9375f8ce9000876ef54
😎 Deploy Preview https://deploy-preview-1398--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@scrocquesel-ml150 scrocquesel-ml150 force-pushed the feat/svcbus_waitstrategy branch from 78d1f94 to 2d8afc3 Compare March 12, 2025 12:11
@scrocquesel-ml150 scrocquesel-ml150 changed the title feat(ServiceBus): Replace wait strategy with HTTP health check feat: Replace wait strategy with HTTP health check Mar 12, 2025
@HofmeisterAn HofmeisterAn added enhancement New feature or request chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups labels Mar 12, 2025
@HofmeisterAn HofmeisterAn changed the title feat: Replace wait strategy with HTTP health check feat(EventHubs, ServiceBus): Replace wait strategy with HTTP health check Mar 12, 2025
HofmeisterAn
HofmeisterAn previously approved these changes Mar 12, 2025
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HofmeisterAn HofmeisterAn merged commit 615f5cc into testcontainers:develop Mar 12, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants