WIP: VNC recording with BrowserWebdriverContainer in Spock-Extension #726
Conversation
| @@ -50,6 +55,15 @@ class TestcontainersMethodInterceptor extends AbstractMethodInterceptor { | |||
|
|
|||
| @Override | |||
| void interceptCleanupMethod(IMethodInvocation invocation) throws Throwable { | |||
| findAllBrowserWebDriverContainers(invocation).each { | |||
There was a problem hiding this comment.
I was thinking about this and it seems that it will result in exporting the video after each failed test..
does it mean we have to restart the container after each test(failed or not)?
or it will just stop the execution?
maybe we want to do this at cleanupSpec time, not sure
There was a problem hiding this comment.
So we actually have to add it to both methods but have a conditional findAllBrowserWebDriverContainers() method, so we get the non-shared containers in interceptCleanupMethod and only the @Shared ones in interceptCleanupSpecMethod.
bsideup
changed the title
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
|
@here guys, any updates on this? It's a very cool feature |
|
Hey @igor-dmitriev, sorry, I should resume work I suppose. |
|
@kiview thank you, actually, it just generates screenshots, but video is not available |
|
This PR just takes screenshots? |
|
@kiview not this one, I meant current version - 1.9.1, it generates screenshots |
|
Are you really talking about the Spock extension? Because it doesn't have this feature in master. |
|
I've just realized that it's not a TestContainers feature, sorry for confusion, I am a newbie with Selenium |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
|
Leave it open. |
|
Hi @kiview, really like this feature (saw your talk at Javaland 2019 and want to use geb, spock and videos from testcontainers). Would be great to see it merged. Thank you & Regards |
|
@srose |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
|
This issue has been automatically closed due to inactivity. We apologise if this is still an active problem for you, and would ask you to re-open the issue if this is the case. |
|
This was released in https://github.com/testcontainers/testcontainers-java/releases/tag/1.14.0 🎉 Thanks for the contribution! |
Roughly poc, still WIP.
Done as part of the Hackergarten at Gr8ConfEU 2018.
Thanks to Tamer Shahin, Marcin Erdmann and Dawid Kublik for working on this 🙂 !
Fixes #631.