Improve PortCheck logging for distroless images #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/testcontainers/src/wait-strategies/utils/port-check-real.test.ts
Outdated
Show resolved
Hide resolved
cristianrgreco
added
enhancement
cristianrgreco
changed the title
|
Oh, I just pushed a commit to this pr, but was late by a minute ) docker-no-shell fixture is also not needed, if we removed integration test. |
|
@digital88 Sorry about that, I want to merge all that I can for the next release, was hoping to get it out today. I've raised #959 to remove those fixtures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #683
The error
The HostPortWaitStrategy will not work on a distroless imagewill be logged regardless oflog.enabled()Distroless containers also return error code 127 when exec non-existent command. Previous logic only tested for error code 126.