theia-electron: include default plugins #299

paul-marechal · 2020-02-06T23:26:27Z

Use a set of VS Code builtin extensions and some non-builtins to provide
more functionality to the Electron example IDE.

Signed-off-by: Paul Maréchal paul.marechal@ericsson.com

theia-electron/package.json

lmcbout · 2020-02-07T13:19:37Z

In package.json, do we want to put in
script :"start": "theia start --plugins=local-dir:./plugins",

Also in plugins section the dependencies of the builtins, add:
vscode-eslint

Also, why not using the electron-builder latest version, "electron-builder": "^22.0.1" (version 22.3.2), it will create the AppImage like

    Theia-0.3.17.AppImage

instead of (quote and space in the name)

  'Theia 0.3.17.AppImage'

paul-marechal · 2020-02-07T16:35:53Z

@spoenemann @akosyakov I only tested that plugins worked when bundled as an AppImage on Ubuntu. I would need help from people on other platforms to check if it works there too.

edit: looks like it works when I install the .deb as well.

@lmcbout I added the start script, even though the real value is in the bundles. I also fixed the name of the AppImage without updating electron-builder, I didn't want to fight with a CQ.

lmcbout · 2020-02-07T16:54:29Z

electron-buider has some fixes with latest version, we should aim to update it even it requires a CQ.
What do you think?

vince-fugnitto · 2020-02-07T17:05:32Z

electron-buider has some fixes with latest version, we should aim to update it even it requires a CQ.
What do you think?

There is no CQ required for this repo since it is not under the Eclipse Foundation.

Something like updating electron-builder can be done in a subsequent pull-request since it is an enhancement. I'd like to unblock this pull-request so we can continue with updating the necessary images and removing deprecated extensions.

paul-marechal · 2020-02-07T18:22:45Z

There is no CQ required for this repo

~~Ok, updated electron-builder.~~ Will remove the commit, I am having issues with it and I don't think it is useful right-now.

theia-electron/scripts/theia-electron-main.js

marcdumais-work · 2020-02-10T12:38:51Z

Tested the AppImage on Ubuntu. @vince-fugnitto could you quickly validate that the plugins are loaded correctly on Windows and Mac?

marcdumais-work · 2020-02-10T12:46:17Z

@marechal-p While you're there, I think the 0.3.17 app version in package.json does not mean much - it was probably the Theia version at the time this app was created, but we do not want to step it every month. I suggest we change it to e.g. 0.0.1 or such. We should probably do this for all images.

(note: the Theia platform version is already reflected in the tag when we publish on dockerhub)

vince-fugnitto · 2020-02-10T15:57:12Z

Tested the AppImage on Ubuntu. @vince-fugnitto could you quickly validate that the plugins are loaded correctly on Windows and Mac?

I verified and it did not work correctly on mac or win.
After performing the updates 33c0027, the electron build worked correctly and the plugins were successfully included/loaded.

Update: Note that on master, the mac build also does not work correctly.

vince-fugnitto

I did a pass on what should be removed/added in the example.
In our list of dependencies we should remove the following:

@theia/merge-conflicts

Please also see my other comments regarding the java plugins not necessary in this example.

theia-electron/package.json

akosyakov · 2020-02-13T10:12:31Z

code-wise it looks good to me

Use a set of VS Code builtin extensions and some non-builtins to provide more functionality to the Electron example IDE. Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>

vince-fugnitto

I'm happy with the latest changes 👍
I verified on macOS that the build is successfully and I am able to consume the listed plugins.

paul-marechal · 2020-02-25T15:27:05Z

theia-electron/scripts/theia-electron-main.js

+process.env.THEIA_PLUGINS = [
+    process.env.THEIA_PLUGINS, `local-dir:${path.resolve(os.homedir(), '.theia', 'plugins')}`,
+].filter(Boolean).join(',')


@akosyakov IIRC when I tested this I was installing unpacked extensions there without any issues.

paul-marechal requested review from kittaakos, marcdumais-work and vince-fugnitto February 6, 2020 23:26

akosyakov mentioned this pull request Feb 7, 2020

remove dependency to monaco-languageclient eclipse-theia/theia#7100

Closed

akosyakov reviewed Feb 7, 2020

View reviewed changes

theia-electron/package.json Show resolved Hide resolved

paul-marechal force-pushed the mp/electron-plugins branch from 3e95478 to 7ba7514 Compare February 7, 2020 16:38

paul-marechal force-pushed the mp/electron-plugins branch from 33c0027 to 7ba7514 Compare February 7, 2020 19:32

marcdumais-work reviewed Feb 10, 2020

View reviewed changes

theia-electron/scripts/theia-electron-main.js Show resolved Hide resolved

paul-marechal force-pushed the mp/electron-plugins branch from 7ba7514 to c291967 Compare February 10, 2020 16:00

vince-fugnitto reviewed Feb 10, 2020

View reviewed changes

theia-electron/package.json Outdated Show resolved Hide resolved

theia-electron/package.json Outdated Show resolved Hide resolved

vince-fugnitto force-pushed the mp/electron-plugins branch 2 times, most recently from b724024 to e868f50 Compare February 11, 2020 16:37

paul-marechal force-pushed the mp/electron-plugins branch from e868f50 to 4ca4868 Compare February 13, 2020 15:48

theia-electron: include default plugins

afed243

Use a set of VS Code builtin extensions and some non-builtins to provide more functionality to the Electron example IDE. Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>

paul-marechal force-pushed the mp/electron-plugins branch from 4ca4868 to afed243 Compare February 13, 2020 15:50

vince-fugnitto approved these changes Feb 13, 2020

View reviewed changes

paul-marechal merged commit 3b0dda9 into theia-ide:master Feb 13, 2020

paul-marechal deleted the mp/electron-plugins branch February 13, 2020 16:09

paul-marechal commented Feb 25, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

theia-electron: include default plugins #299

theia-electron: include default plugins #299

paul-marechal commented Feb 6, 2020

lmcbout commented Feb 7, 2020

paul-marechal commented Feb 7, 2020 •

edited

Loading

lmcbout commented Feb 7, 2020 •

edited by vince-fugnitto

Loading

vince-fugnitto commented Feb 7, 2020

paul-marechal commented Feb 7, 2020 •

edited

Loading

marcdumais-work commented Feb 10, 2020

marcdumais-work commented Feb 10, 2020

vince-fugnitto commented Feb 10, 2020 •

edited

Loading

vince-fugnitto left a comment

akosyakov commented Feb 13, 2020

vince-fugnitto left a comment

paul-marechal Feb 25, 2020

theia-electron: include default plugins #299

theia-electron: include default plugins #299

Conversation

paul-marechal commented Feb 6, 2020

lmcbout commented Feb 7, 2020

paul-marechal commented Feb 7, 2020 • edited Loading

lmcbout commented Feb 7, 2020 • edited by vince-fugnitto Loading

vince-fugnitto commented Feb 7, 2020

paul-marechal commented Feb 7, 2020 • edited Loading

marcdumais-work commented Feb 10, 2020

marcdumais-work commented Feb 10, 2020

vince-fugnitto commented Feb 10, 2020 • edited Loading

vince-fugnitto left a comment

Choose a reason for hiding this comment

akosyakov commented Feb 13, 2020

vince-fugnitto left a comment

Choose a reason for hiding this comment

paul-marechal Feb 25, 2020

Choose a reason for hiding this comment

paul-marechal commented Feb 7, 2020 •

edited

Loading

lmcbout commented Feb 7, 2020 •

edited by vince-fugnitto

Loading

paul-marechal commented Feb 7, 2020 •

edited

Loading

vince-fugnitto commented Feb 10, 2020 •

edited

Loading