Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make CollectionBinder optionally an AMD #111

Closed
wants to merge 1 commit into from
Closed

make CollectionBinder optionally an AMD #111

wants to merge 1 commit into from

Conversation

rweng
Copy link

@rweng rweng commented Feb 6, 2013

I had trouble when optimizing my js code with requirejs, because CollectionBinder executed as soon as it was loaded, whereas ModelBinder was an AMD und thus not yet defined.

So I propose making CollectionBinder an AMD, too.

@DocLabyrinth
Copy link

I'm also encountering this problem when trying to make an optimised build which includes the two files. It's possible to concatenate them during the build process or wrap the collection binder manually, but additionally having the AMD define call in the collection binder would make life easier.

@raresvla
Copy link

+1

1 similar comment
@jefftougas
Copy link

👍

@bharatpatil
Copy link

Wow!!! Thanks...!!!

@gaydenko
Copy link

While this bug fixing is still pending during almost a year, can anybody please explicitly explain how to workaround the issue with "Please include Backbone.ModelBinder.js before Backbone.CollectionBinder.js" exception?

@bharatpatil
Copy link

@gaydenko - If I correctly understood you, Copy and paste green lines from "File Changed" tab above in Backbone.ModelBinder.js (of course overright red lines).

@gaydenko
Copy link

I have tried - there was an error on requerjs building, but after removing ModelBinder from define array (I mean that patch) I have got built project at last (dependencies are defined in requirejs config file). Thanks!

@crebuh
Copy link

crebuh commented Oct 29, 2014

would be great if this could be integrated into the current release?

@cliren
Copy link

cliren commented Nov 5, 2014

@theironcook did you get a chance to merge the amd support PR for collection binder?

@theironcook
Copy link
Owner

The latest (v1.0.6) has this feature.

@theironcook theironcook closed this Nov 5, 2014
@cliren
Copy link

cliren commented Nov 5, 2014

great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants