Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email address check is case-sensitive on login but not on user creation #114

Closed
myersjustinc opened this issue May 11, 2017 · 2 comments
Closed

Comments

@myersjustinc
Copy link
Contributor

When I attempt to log in to our internal Klaxon instance, I have to type my email address with the exact capitalization that's shown in /users. When I attempt to log in with the same email address but with different capitalization, I get an "Email Not Found" error.

The User model does a case-insensitive check for uniqueness, but SessionsController#create uses the email address exactly as the user provided it.

Seems like case-insensitivity is the way to go. Happy to take an initial stab at updating the controller, unless anyone else gets to it first.

@GabeIsman
Copy link
Member

@myersjustinc Ah nice catch. I agree with your assessment. Should just be case-insensitive everywhere. Please do take a stab at updating! Thanks.

@GabeIsman
Copy link
Member

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants