Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:) #1

Merged
merged 2 commits into from
Oct 6, 2023
Merged

:) #1

merged 2 commits into from
Oct 6, 2023

Conversation

brillout
Copy link
Contributor

@brillout brillout commented Oct 6, 2023

No description provided.

@thomasjm
Copy link
Owner

thomasjm commented Oct 6, 2023

Thanks @brillout !

This does help, although it's a bit weird because it depends on ../dist/server/importBuild.cjs already existing. You basically have to run the build once without that import statement, and then run it again with the statement to get things to work. And of course you could get weird bugs if the file was stale.

I'm wondering if there's a way to fix this so it works with a single build from an empty directory? Maybe a pre-build step could generate importBuild.cjs first?

@brillout
Copy link
Contributor Author

brillout commented Oct 7, 2023

I'm not sure I understand what you mean (seems like you have a wrong perception of how things work). FYI avoiding the difficulties you encountered and making things simpler is very much on the radar.

@thomasjm
Copy link
Owner

thomasjm commented Oct 7, 2023

Look, this is easy to verify -- just run the build of your branch in a clean directory and it will fail.

cd $(mktemp -d)
git clone git@github.com:brillout/vike-standalone.git
cd vike-standalone
pnpm install
pnpm run build

It's because you've tried to import a product of the previous build.

@brillout
Copy link
Contributor Author

brillout commented Oct 8, 2023

I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants