Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with pip<=21.1.1 #167

Merged
merged 1 commit into from
May 13, 2021
Merged

Test with pip<=21.1.1 #167

merged 1 commit into from
May 13, 2021

Conversation

fridex
Copy link
Collaborator

@fridex fridex commented May 11, 2021

This introduces a breaking change

  • No

@sesheta sesheta requested a review from KPostOffice May 11, 2021 14:46
@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2021
@sesheta
Copy link
Member

sesheta commented May 11, 2021

Pre-Commit Test failed! Click here
[INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pycqa/pydocstyle.git.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy.
[INFO] Initializing environment for https://github.com/psf/black.
[INFO] Initializing environment for https://gitlab.com/PyCQA/flake8.
[INFO] Initializing environment for https://gitlab.com/PyCQA/flake8:pep8-naming.
[INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for git://github.com/pycqa/pydocstyle.git.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/psf/black.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://gitlab.com/PyCQA/flake8.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Passed
Check for merge conflicts................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
check BOM - deprecated: use fix-byte-order-marker........................Passed
Check for case conflicts.................................................Passed
Check docstring is first.................................................Passed
Check JSON...............................................................Passed
Detect Private Key.......................................................Passed
Check python ast.........................................................Passed
Debug Statements (Python)................................................Passed
pydocstyle...............................................................Passed
Check Toml...............................................................Passed
Check Yaml...............................................................Passed
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

.github/workflows/prep_windows_matrix.py:14:38: error: Item "None" of "Optional[Match[str]]" has no attribute "groups"  [union-attr]
Found 1 error in 1 file (checked 2 source files)

black....................................................................Passed
flake8...................................................................Passed

@frenzymadness
Copy link
Collaborator

There are a lot of mypy errors. I'm not sure yet where are they coming from.

@fridex fridex mentioned this pull request May 12, 2021
1 task
@fridex
Copy link
Collaborator Author

fridex commented May 12, 2021

There are a lot of mypy errors. I'm not sure yet where are they coming from.

It's not clear to me why windows tests fail. Tests report Error: The operation was canceled.. A search for a similar issue on GitHub pointed to actions/runner-images#1918 (memory issues). Not sure if that's the case for us (?).

@fridex
Copy link
Collaborator Author

fridex commented May 12, 2021

There are a lot of mypy errors. I'm not sure yet where are they coming from.

It's not clear to me why windows tests fail. Tests report Error: The operation was canceled.. A search for a similar issue on GitHub pointed to actions/virtual-environments#1918 (memory issues). Not sure if that's the case for us (?).

Hm, could these tests be terminated as https://github.com/thoth-station/micropipenv/pull/167/checks?check_run_id=2557409417 is failing? Then I see your point about mypy errors.

@frenzymadness
Copy link
Collaborator

I'm running all the tests locally so we can merge this and make the new test from #170 happy and we can then focus on the mypy errors on widows.

@frenzymadness
Copy link
Collaborator

Also, there are many changes in typing in the latest pip so the errors might come from some difference there.

Copy link
Collaborator

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that all tests are passing locally.

@sesheta
Copy link
Member

sesheta commented May 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frenzymadness

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2021
@fridex
Copy link
Collaborator Author

fridex commented May 13, 2021

Great, thanks for confirming. Let's merge then. 👍🏻

@fridex fridex merged commit b7dc032 into thoth-station:master May 13, 2021
@fridex fridex deleted the pip-21-1-1 branch May 13, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants