-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test with pip<=21.1.1 #167
Conversation
Pre-Commit Test failed! Click here
|
There are a lot of mypy errors. I'm not sure yet where are they coming from. |
It's not clear to me why windows tests fail. Tests report |
Hm, could these tests be terminated as https://github.com/thoth-station/micropipenv/pull/167/checks?check_run_id=2557409417 is failing? Then I see your point about mypy errors. |
I'm running all the tests locally so we can merge this and make the new test from #170 happy and we can then focus on the mypy errors on widows. |
Also, there are many changes in typing in the latest pip so the errors might come from some difference there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that all tests are passing locally.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frenzymadness The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Great, thanks for confirming. Let's merge then. 👍🏻 |
This introduces a breaking change