Github Actions CI #306
Github Actions CI #306
Conversation
Initial work to test Github actions against Ruby 2.7 and the Rails 5.0 gemspec in order to see if matrix optoins can work for each.
Running under bundle exec for `rake spec`
Checking all provided gemspecs of Rails that were originally generated by appraisal.
Describe the gemfile we are setting up Ruby with in the Github Action workflow.
Gemfile name was added to the step, but also adding to the entire action so that it's easier to view at a glance.
Based off of what we were running for Travis CI, running for Ruby 2.4 up to 2.7, and excluding Rails 6 from Ruby 2.4 as we did on Travis.
Use the default version of rubygems that ships with each version of ruby rather than attempting to update to latest.
Update README for Github Action badge and run when pushed to main. Also note changes in CHANGELOG
Removing in favor of Github Actions
.github/workflows/ci.yml
Outdated
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| ruby-version: ['2.4', '2.5', '2.6', '2.7'] |
There was a problem hiding this comment.
How do you feel about running this against 2.7, 3.0, 3.1, and 3.2 instead. I think everything pre-2.7 is EOL now
There was a problem hiding this comment.
That's a good call out. I went initially just for parity with the Travis CI setup, but perhaps let's see if they pass in supported versions. Will check this out.
There was a problem hiding this comment.
Updated to test on Ruby 2.7, 3.0, 3.1 and 3.2. Also updated to test Rails 6.1 and Rails 7.0. Removed testing in Rails 5.x the the exception of Rails 5.2 (under Ruby 2.7).
Considered updating the gemspec as well to bump from Rails 5.0 to Rails 5.2 as the minimum supported Rails version, but didn't know if that should be a separate PR @brimatteng?
There was a problem hiding this comment.
No strong feelings about it. It seems like it makes sense here
- Test against non EOL Ruby versions. - Only Test Rails 5.x for Rails 5.2 - Adding Rails 6.1 and Rails 7.0
Technically Rails 5.2 doesn't officially support Ruby 2.7, let alone Ruby 3.x, but keeping it around to test in just Ruby 2.7
Exclude syntax doesn't support lists, and we really just one one extra job here, so switching to using a single include to include it.
Removing Travis CI in favor of Github Actions. Running against the same Rails versions and Ruby versions as we did with Travis CI for now.
Also updated the README to reference the Github Actions status badge for
mainand noted the update in the CHANGELOG.