EOL Rails 5.0 and Rails 5.1 #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Being we no longer run automated tests against these versions of Rails this removes support for them in the gem. Dropping support for Rails 5.0 also allows us to bump `rspec-rails` to be using `4.0.0` at minimum.
MatheusRich
approved these changes
Oct 20, 2023
|
Good question on dropping 5.2. We dropped 4.2 in 2019 (two years after it's security releases stopped). Not that we'd have to go by that, but if we did, it looks like we'd keep 5.2 around until Summer of 2024? |
|
@keegnotrub sounds good. ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being we no longer run automated tests against these versions of Rails this removes support for them in the gem.
Dropping support for Rails 5.0 also allows us to bump
rspec-railsto be using4.0.0at minimum.