Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new TwoPhaseCommitter constructor #774

Closed
jackjeyis opened this issue Jan 11, 2024 · 1 comment
Closed

add new TwoPhaseCommitter constructor #774

jackjeyis opened this issue Jan 11, 2024 · 1 comment
Labels
type/feature-request New feature request

Comments

@jackjeyis
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe:
TwoPhaseCommitter constructor can not support Customized thread pool size

Describe the feature you'd like:
public TwoPhaseCommitter(TiSession session, long startTime, long lockTTL,ExecutorService executorService) {
this(
session,
startTime,
lockTTL,
TXN_COMMIT_BATCH_SIZE,
TXN_COMMIT_BATCH_SIZE,
WRITE_BUFFER_SIZE,
1,
true,
3,
executorService
}

Describe alternatives you've considered:
default pool size too large and every TwoPhaseCommitter obejct have new ExecutorService

Teachability, Documentation, Adoption, Migration Strategy:
TwoPhaseCommitter twoPhaseCommitter = new TwoPhaseCommitter(session, startTime, lockTTL, executorService);

@jackjeyis jackjeyis added the type/feature-request New feature request label Jan 11, 2024
@jackjeyis
Copy link
Contributor Author

help me see see

jackjeyis pushed a commit to jackjeyis/client-java that referenced this issue Jan 18, 2024
jackjeyis pushed a commit to jackjeyis/client-java that referenced this issue Jun 3, 2024
jackjeyis pushed a commit to jackjeyis/client-java that referenced this issue Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request New feature request
Projects
None yet
Development

No branches or pull requests

1 participant