-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[close #231] TiKV-BR support v5.x.x #282
Conversation
Signed-off-by: haojinming <jinming.hao@pingcap.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
================================================
- Coverage 54.4448% 54.3570% -0.0879%
================================================
Files 238 239 +1
Lines 20237 20312 +75
================================================
+ Hits 11018 11041 +23
- Misses 8341 8393 +52
Partials 878 878
*This pull request uses carry forward flags. Click here to find out more.
|
Signed-off-by: haojinming <jinming.hao@pingcap.com>
Signed-off-by: haojinming <jinming.hao@pingcap.com>
Signed-off-by: haojinming <jinming.hao@pingcap.com>
…nto br_support_v5.x.x
Store: store, | ||
} | ||
}) | ||
failpoint.Inject("tikv-region-error", func(val failpoint.Value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we verified that the failpoint is effective ? This failpoint should cause an incomplete range and enter procedure fineGrainedBackup
. I remember that there was a message "start fine grained backup" in log printed here, but I can't find it in CI logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will change the original behavior, as all regions will fail, other than only one of them. In real scenarios, there should be only a small number of regions will fail.
I think we can change FAILPOINTS
of rawkv test from return("region error")
to 1*return("region error")
to control how many times the failpoint takes effective.
Refer to here (this change add a "one region fail" case in addition to "all regions").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks.
Signed-off-by: haojinming <jinming.hao@pingcap.com>
…nto br_support_v5.x.x
Signed-off-by: haojinming <jinming.hao@pingcap.com>
Signed-off-by: haojinming <jinming.hao@pingcap.com>
Signed-off-by: haojinming <jinming.hao@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM.
br/Makefile
Outdated
@@ -31,6 +31,7 @@ TEST_PARALLEL ?= 8 | |||
PD_ADDR ?= 127.0.0.1:2379 | |||
BR_LOCAL_STORE ?= /tmp/backup_restore_test | |||
API_VERSION ?= 1 | |||
CLUSTER_VERSION?= nightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: add a space before ?=
and align other lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: haojinming <jinming.hao@pingcap.com>
…nto br_support_v5.x.x
Signed-off-by: haojinming <jinming.hao@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
/verify |
Force merge. Fix cdc integrated tests in another PR. |
Signed-off-by: haojinming jinming.hao@pingcap.com
What problem does this PR solve?
Issue Number: close #231
Problem Description: =
What is changed and how does it work?
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes