Default behaviour - to include Cellar kegs and option to disable it #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
included formula Cellar directory
|
Hi @kaloprominat, thanks for bringing me back up to speed on this and for the work you've done - sorry to have neglected it. I'm afraid I can't spend much time in the next week to look at this, but I do intend to. I'd like to eventually find a way that we could test against a larger corpus of formulae (using the formula's test methods, for example) to really verify that packages are properly working when installed. Git is probably a pretty good candidate for being a more complex package layout, though. This is related to #4, so referencing that here too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, timsutton.
As some users mentioned at issues page, brew pkg skips kegs in Cellar directory, but many packages compiled with static linking to those directories. I've modified brew pkg default behaviour to include package kegs too and added option --without-kegs to disable it.
Looking forward for your review. Thanks.