sidebar: recent sorting #1205
Merged
sidebar: recent sorting #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tomholford
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I think I sent @tomholford down the wrong path for #1114 my apologies! The
brief.lastis the correct thing to use for the last message we just had a few issues. We weren't using nests, looking at all channel types, updating briefs for posts in all channel types, and our chat brief was going off out of order so it was always one behind. This corrects all of that and also changes the default sort for channels to arranged and default heap view to grid.This does rip out the channel prefetching which I think we need to revisit after launch. The prefetching was incurring too many requests + subscriptions holding up loading anything else for like 10s+ which I think is not a decent enough trade off yet. Also we don't really want to be subscribed to all channel updates because that was why we split them out in the first place.