Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native: add invite prompt before waitlisting #3972

Merged
merged 9 commits into from
Oct 1, 2024

Conversation

latter-bolden
Copy link
Member

@latter-bolden latter-bolden commented Oct 1, 2024

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-01.at.00.42.27.mp4

Fixes TLON-2858

The text field with button needs to be hardened (spacing checked against Ochre, better error state handling, etc.), but should otherwise be ready for review

@arthyn
Copy link
Member

arthyn commented Oct 1, 2024

cleannnnn

@latter-bolden latter-bolden marked this pull request as ready for review October 1, 2024 15:20
Copy link
Member

@jamesacklin jamesacklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX looks great. I think we should say something like, "This app is still in its early stages, but if someone invited you...". That way the concept of a "waitlist" makes a little more sense.

@e-shee Any thoughts here?

@jamesacklin
Copy link
Member

Note for other reviewers: this shows up between the "do we have inventory for this cold install, that doesn't have a Lure via Branch" check and the "you don't have a Lure and we don't have inventory, join the waitlist" check.

This is a fail-safe if Branch fails to pass the Lure through across the app installation (near 100% chance if installing via TestFlight).

@e-shee
Copy link

e-shee commented Oct 1, 2024

UX looks great. I think we should say something like, "This app is still in its early stages, but if someone invited you...". That way the concept of a "waitlist" makes a little more sense.

@e-shee Any thoughts here?

Let's just say something like: "This is a new kind of app. We're growing slowly. Invites let you skip the waitlist because we know someone wants to talk to you here." If that's too long I can condense.

Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@latter-bolden latter-bolden merged commit bd4411a into develop Oct 1, 2024
1 check passed
@latter-bolden latter-bolden deleted the lb/invite-link-screen branch October 1, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants