Fix optional AsSingleOpenApiParam #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulanzetz
requested review from
danslapman,
eld0727,
Odomontois and
valentiay
as code owners
ulanzetz
force-pushed
the
fix-openapi-opt-param
branch
from
895a06e to
be633ab
Compare
Odomontois
approved these changes
Jan 25, 2021
REDNBLACK
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
In case if AsSingleOpenApiParam for Option[T] and instance of SwaggerTypeable[Option[T]] is inferred, typed-schema picks AsOpenParamInstances.requiredParam branch as more simple than AsOpenParamInstances.optParam.
For example,
header[Option[String]]("X-Kek-Id")will be required in OpenAPI.This solution will fix it and safe other cases logic